Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wixtoolset) Change to only track GitHub v3 releases #2197

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

AdmiringWorm
Copy link
Member

Description

The website looks have changed, which makes it harder to parse the website. With this in mind this pull request changes to track the v3 releases available on GitHub through our custom API helper instead.
We need to keep an eye on the development in v4 for this, in case they decide to release a full installer for it but as of right now that isn't available.

Ref #2187 (remember to tick the task for wixtoolset when merging)

Motivation and Context

To get the automatic updater fixed.

How Has this Been Tested?

  1. Run .\update_all.ps1 wixtoolset -ForcedPackages wixtoolset
  2. Verify it created a new fix version successfully.
  3. Restore a snapshot of chocolatey-test-environment
  4. Run choco install wixtoolset --source "C:\packages;chocolatey" (change C:\packages to where you have the wixtoolset package)
  5. Verify it successfully installed
  6. Run choco uninstall wixtoolset
  7. Verify it successfully uninstalled

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Due to changes upstream on the website, to make continued checks as easy
as possible this commit changes to explicitly only track releases made on GitHub
for version 3 of the software.

ref chocolatey-community#2187
The only reason remaining to keep a dependency on chocolatey-core.extension
is to provide backwards functionality to Chocolatey CLI v0.10.15 (or earlier).
As this is outside of the range we support, there is no longer a need for this
dependency
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 55db2df into chocolatey-community:master Mar 28, 2023
@gep13
Copy link
Member

gep13 commented Mar 28, 2023

@AdmiringWorm thanks for getting this fixed up!

@AdmiringWorm AdmiringWorm deleted the wixtoolset-fix branch March 28, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants